Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/disable identity auto creation #281

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Feature/disable identity auto creation #281

wants to merge 12 commits into from

Conversation

sebbi08
Copy link
Contributor

@sebbi08 sebbi08 commented Oct 9, 2024

Readiness checklist

  • I added/updated tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@sebbi08 sebbi08 added the wip Work in Progress (blocks mergify from auto update the branch) label Oct 9, 2024
@codecov Codecov
Copy link

codecov bot commented Oct 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 91.82156% with 22 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cli/BaseCommand.ts 84.37% 15 Missing ⚠️
src/cli/index.ts 80.00% 6 Missing ⚠️
src/jsonSchemas/connectorConfig.ts 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/ConnectorRuntime.ts 80.34% <ø> (+1.32%) ⬆️
src/ConnectorRuntimeConfig.ts 100.00% <100.00%> (+100.00%) ⬆️
src/cli/commands/identity/init.ts 100.00% <100.00%> (ø)
src/cli/commands/start.ts 100.00% <100.00%> (ø)
src/jsonSchemas/connectorConfig.ts 0.00% <0.00%> (ø)
src/cli/index.ts 80.00% <80.00%> (ø)
src/cli/BaseCommand.ts 84.37% <84.37%> (ø)

... and 1 file with indirect coverage changes

@sebbi08 sebbi08 force-pushed the feature/disable-identity-auto-creation branch from 99be0e4 to c272a26 Compare October 17, 2024 09:27
@sebbi08 sebbi08 force-pushed the feature/disable-identity-auto-creation branch from c272a26 to e20be9d Compare October 17, 2024 10:36
@sebbi08 sebbi08 added the enhancement New feature or request label Oct 17, 2024
@sebbi08 sebbi08 force-pushed the feature/disable-identity-auto-creation branch from 74012fb to 34e7560 Compare October 17, 2024 10:47
@sebbi08 sebbi08 force-pushed the feature/disable-identity-auto-creation branch from da4097b to 4f963a9 Compare October 17, 2024 11:12
@sebbi08 sebbi08 force-pushed the feature/disable-identity-auto-creation branch 2 times, most recently from 4f963a9 to a145fc0 Compare October 17, 2024 11:40
@sebbi08 sebbi08 force-pushed the feature/disable-identity-auto-creation branch from a145fc0 to 34672d6 Compare October 17, 2024 11:53
@sebbi08 sebbi08 force-pushed the feature/disable-identity-auto-creation branch from 34672d6 to 1240279 Compare October 17, 2024 12:13
@sebbi08 sebbi08 changed the base branch from main to feature/convert_connector_to_cli October 28, 2024 07:31
Base automatically changed from feature/convert_connector_to_cli to main October 31, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request wip Work in Progress (blocks mergify from auto update the branch)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sebbi08